D15990: Makes the Code Editor Widget tabs closable.

[Tomaz Canabrava]

tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> project.cpp:256
>      QString path = document->url().toString();
> -    document->closeUrl();
> +    if (!document->closeUrl()) return;
>      int index = d->m_codeDocuments.indexOf(document);

code style, return in the next line.

> codeeditorwidget.cpp:27
>  #include <KLocalizedString>
> +#include <QMessageBox>
>  #include <QInputDialog>

stray include.

> codeeditorwidget.cpp:111
> +{
> +    m_project->removeCodeDocument(m_project->codeDocuments().at(index));
> +}

While this removeCodeDocument will not remove if the KTextDocument says that it will not close, this is not obvious.
can you rename to tryToRemoveCodeDocument?

REPOSITORY
  R73 Rocs

REVISION DETAIL
  https://phabricator.kde.org/D15990

To: fernandorodrigues, tcanabrava
Cc: cordlandwehr, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181008/e04c288f/attachment.html>