D15937: Do not alter the state of the Scheduler while evaluating

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
TallFurryMan added a project: KDE Edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  This differential does a few rewrites, removes a few logs from the console and essentially removes the shutdown decision from the evaluation algorithm.
  
  - Avoided multiple evaluations while loading a schedule, introduced a new Scheduler state for this purpose.
  - Prevented moving jobs in the list when option "Sort jobs by Altitude and Priority" is enabled, added tips.
  - Reduced amount of logs, fix date display, fix some logs.
  - Avoided evaluating a repeating job that just completed, shorted to completion.
  - Rewrote, clarified and added fixmes and asserts in the final part of evaluation, sequencing jobs (no change).
  - Moved decision to shutdown from the evaluation function off to the status check function.

TEST PLAN
  Verify this differential brings no change of behavior with the all scheduler test vectors.
  Observe the console reduced output as most technical logs were moved to the file journal.
  Observe the console as loading a dozen schedule jobs does not result in dozens of evaluations.
  Observe move buttons following the state of option "Sort jobs by Altitude and Priority".

REPOSITORY
  R321 KStars

BRANCH
  improve__some_rewrites (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15937

AFFECTED FILES
  kstars/ekos/ekos.h
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181004/de0f717f/attachment.html>