D15928: Port Step away from kdelibs4support

Christoph Feck noreply at phabricator.kde.org
Wed Oct 3 20:42:12 BST 2018


cfeck added inline comments.

INLINE COMMENTS

> mainwindow.cc:47
>  #include <KStandardAction>
> -#include <KStatusBar>
> +#include <QStatusBar>
>  #include <KToolBarPopupAction>

Did you check if there are no visual regressions when porting to QStatusBar? The KDELibs version did a few things differently.

> worldscene.cc:129
>      resetMatrix();
> -    scale(1/_viewScale, -1/_viewScale);
>  }

You can combine `resetMatrix()` + `setTransform(..., true)` with `setTransform(..., false)`

REPOSITORY
  R341 Step

REVISION DETAIL
  https://phabricator.kde.org/D15928

To: yurchor, #kde_edu
Cc: cfeck, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181003/7c205677/attachment-0001.html>


More information about the kde-edu mailing list