D17120: Implement zooming with Ctrl+mouse wheel

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> view.cpp:3401
> +		// Disable animation?
> +		if (e->delta() > 0)
> +		{

You may want to accumulate the deltas, some touchpads send lots of events with very small deltas, so just doing >0 and <0 can make it very difficult to control, see https://cgit.kde.org/okular.git/commit/?id=7a50ce0edfc9be8bd23441e52a4f3a0c60f7e60f

> view.h:86
>  	Q_OBJECT
> +	Q_PROPERTY( QRectF viewport READ getViewport WRITE setViewport )
>  	public:

What is this propety and the new functions for? They are never called, no?

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D17120

To: yurchor, #kde_edu, tcanabrava
Cc: aacid, tcanabrava, kde-edu, kde-doc-english, skadinna, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181128/540a32f4/attachment-0001.html>