D17120: Implement zooming with Ctrl+mouse wheel

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> view.cpp:3646
>  	{
> -		// zooming in
> -		beginTL = newCoords.topLeft();
> -		beginBR = newCoords.bottomRight();
> -		endTL = QPointF( m_xmin, m_ymin );
> -		endBR = QPointF( m_xmax, m_ymax );
> +		m_viewportAnimation = new QPropertyAnimation( this, "viewport" );
> +		m_viewportAnimation->setDuration( 150 );

You either need to delete the existing one or not create one every single time otherwise we end up with lots of qpropertyanimations when we don't really need that many, no?

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D17120

To: yurchor, #kde_edu, tcanabrava
Cc: aacid, tcanabrava, kde-edu, kde-doc-english, skadinna, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181126/20b04072/attachment.html>