D16839: Force black pen when painting unstyled TextLabel

Mikhail Rudenko noreply at phabricator.kde.org
Mon Nov 12 16:01:34 GMT 2018


mikhailru created this revision.
mikhailru added a reviewer: LabPlot.
mikhailru added a project: LabPlot.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
mikhailru requested review of this revision.

REVISION SUMMARY
  The color of default plot axes labels is taken from the theme. This
  results in the labels being barely visible when using dark Qt
  theme (e.g. Breeze Dark). Because plot background is white by default
  independently of the Qt theme, it makes sense to force black color for
  unstyled axes labels (TextLabels). This patch does not affect
  rendering of styled TextLabels.
  
  BUG: 400968

TEST PLAN
  0. Set color theme to Breeze Dark
  
  1. Create new project, new spreadsheet
  2. "Generate data -> row numbers" on both columns
  3. "Plot data -> xy-Curve"
  4. Axes labels should be black by default
  5. Change axis label foreground color to a different one (e.g. red)
  6. Label should be red now

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D16839

AFFECTED FILES
  src/backend/worksheet/TextLabel.cpp

To: mikhailru, #labplot
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181112/50fc6f65/attachment.html>


More information about the kde-edu mailing list