D16775: Fix using comma decimal separator in multiple argument functions

[Yuri Chornoivan]

yurchor created this revision.
yurchor added reviewers: KDE Edu, Localization.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
yurchor requested review of this revision.

REVISION SUMMARY
  Using the comma as a decimal separator in multiple argument functions confuses KmPlot parser.
  
  BUG: 267203
  
  https://bugs.kde.org/show_bug.cgi?id=267203
  
  On the other hand, it is natural to separate numbers with comma separator using the comma with space, e.g. "(0,5, 0,5)", so it is enough to replace the "<number>,<number>" sequences with "<number>.<number>" to obtain the correct results.

TEST PLAN
  1. Plot "f(x) = max(sin(x),cos(x))" in KmPlot with some locale which uses the comma as a decimal separator (according to Wikipedia, this can be a Europian (non-Brittish), Western Asian, Western African or South American locale, e.g. "de", "ca, "es", "uk", "pt_BR"). The result should be correct.
  
  2. Plot "f(x) = max(0,5∙sin(x),cos(x))" in KmPlot. Everything should be fine as well.

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D16775

AFFECTED FILES
  kmplot/parser.cpp

To: yurchor, #kde_edu, #localization
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181109/3ada122d/attachment.html>