D15518: Editor - Line highlighting color fix

Christoph Feck noreply at phabricator.kde.org
Mon Nov 5 11:08:58 GMT 2018


cfeck added inline comments.

INLINE COMMENTS

> editor.h:152
> +						highlight.hue(),
> +						(palette().brush(backgroundRole()).color()).saturation() + EXTRA_SATURATION,
> +						(palette().brush(backgroundRole()).color()).value());

You need to range-limit the saturation value, otherwise Qt just outputs a qWarning and returns an invalid color.

http://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/painting/qcolor.cpp#n1080

REPOSITORY
  R337 KTurtle

BRANCH
  mvalentino

REVISION DETAIL
  https://phabricator.kde.org/D15518

To: mvalentino, tcanabrava, #kde_edu
Cc: cfeck, aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181105/24a257ed/attachment.html>


More information about the kde-edu mailing list