D16429: [WIP] Rewrite of Scheduler planning

[Jasem Mutlaq]

mutlaqja requested changes to this revision.
mutlaqja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> scheduler.cpp:645
> +    {
> +        QTableWidgetItem *nameCell = new QTableWidgetItem();
> +        queueTable->setItem(currentRow, static_cast<int>(SCHEDCOL_NAME), nameCell);

Would this lead to memory leak or is it reparented when setItem(..) is used?

> scheduler.cpp:942
>      jobEvaluationOnly = true;
> -    evaluateJobs();
> +    evaluateJobs();;
>  }

extra ;

> scheduler.cpp:977
>      jobEvaluationOnly = true;
> -    evaluateJobs();
> +    evaluateJobs();;
>  }

extra ;

> scheduler.cpp:1432
> +                            {
> +                                appendLogText(i18n("Warning: job '%1' has no night time with an altitude above %2 degrees during the next 24 hours, marking invalid.",
> +                                            job->getName(),

can such jobs be scheduled later than 24 hours later?

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D16429

To: TallFurryMan, mutlaqja, wreissenberger
Cc: yurchor, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181103/05e1d324/attachment.html>