D15518: Editor - Line highlighting color fix

Tomaz Canabrava noreply at phabricator.kde.org
Fri Nov 2 16:44:10 GMT 2018


tcanabrava requested changes to this revision.
tcanabrava added a comment.
This revision now requires changes to proceed.


  Just this small thing and it can go in.

INLINE COMMENTS

> editor.h:148
> +		//method to adjust highlighting colors according to user theme
> +		QColor getHighlightColor(QColor type){
> +			QColor highlight;

const QColor&

pass the variable via reference, as it will eliminate the copy created between calls.

REPOSITORY
  R337 KTurtle

REVISION DETAIL
  https://phabricator.kde.org/D15518

To: mvalentino, tcanabrava, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181102/5293893c/attachment.html>


More information about the kde-edu mailing list