D16463: QtMath now provides M_PI constant, operations with degrees, and c++ provides round()
Tomaz Canabrava
noreply at phabricator.kde.org
Fri Nov 2 16:28:37 GMT 2018
tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> directiondialog.cpp:375
> skipValueChangedEvent = true;
> - directionSpin->setValue(ROUND2INT(deg));
> + directionSpin->setValue((int)round(deg));
> updateCommandBox();
this style of casting will give us a lot of warnings when compilling with clang.
create a function that does a static_cast<int>(double) and return the int to get rid of the warnings.
REPOSITORY
R337 KTurtle
REVISION DETAIL
https://phabricator.kde.org/D16463
To: Shroudmaster, tcanabrava, rizzitello
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181102/7ae8719e/attachment.html>
More information about the kde-edu
mailing list