D13236: piano_composition, add display of lyrics

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> MultipleStaff.qml:204
>  
> -    function eraseAllNotes() {
> +    function eraseAllNotes(clearLyrics) {
>          for(var v = 0 ; v <= currentStaff ; ++ v)

I don't like the idea of clearing the lyrics on an eraseAllNotes function, is there another way to do it?

> Piano_composition.qml:282
>  
> +        Rectangle {
> +            id: lyricsArea

you can probably create a new file for this

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D13236

To: amankumargupta, #gcompris_activities
Cc: jjazeix, kde-edu, #gcompris_activities, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180531/0a792bbc/attachment-0001.html>