D13088: piano_composition, add replace and edit features.

[Johnny Jazeix]

jjazeix accepted this revision.
jjazeix added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> MultipleStaff.qml:40
> +    // Stores the note number and the staff number in which the replacable note is.
> +    property var noteToReplace: [-1, -1]
>      property bool noteIsColored

can you use a var noteToReplace: {"noteNumber": -1, "staffNumber": -1} instead?

> Note.qml:62
> +            return 0
> +        else if(noteDetails.positonOnStaff > 6 && noteType === "Whole")
> +            return 180

why 6 is hardcoded?

> Note.qml:62
> +            return 0
> +        else if(noteDetails.positonOnStaff > 6 && noteType === "Whole")
> +            return 180

positionOnStaff (missing 'i')

> Note.qml:119
> +            if(noteDetails === undefined || noteType === "" || noteType === "Rest" || noteName === "")
> +                return -6
> +            else if((blackType === "") && (whiteNoteName[noteName[0]] != undefined))

why -6, can you create a readonly property for it?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D13088

To: amankumargupta, #gcompris_activities, jjazeix
Cc: jjazeix, kde-edu, #gcompris_activities, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180526/2937e856/attachment.html>