D13047: piano_composition, added rests.

Aman Kumar Gupta noreply at phabricator.kde.org
Thu May 24 06:57:41 UTC 2018

amankumargupta added inline comments.


> jjazeix wrote in SwitchableOptions.qml:42
> why 4 is hardcoded?

Actually yes, you are right. I should not hardcode it.
We can have another set of options whose length is not 4 (I saw its need today for adding erase and replace features).
I'll give the options array to this file and will do here % options.length. Cause for now, it'll cause conflict in applying the diff and the task I've almost finished. So, I'll update it in the next diff.

  R2 GCompris


To: amankumargupta, #gcompris_improvements
Cc: jjazeix, kde-edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180524/50cea4aa/attachment.html>

More information about the kde-edu mailing list