D12998: Fix bug with missing output for vectors in R backend
noreply at phabricator.kde.org
Sun May 20 15:20:18 UTC 2018
asemke accepted this revision.
asemke added a comment.
This revision is now accepted and ready to land.
In D12998#265483 <https://phabricator.kde.org/D12998#265483>, @sirgienko wrote:
> In D12998#265482 <https://phabricator.kde.org/D12998#265482>, @asemke wrote:
> > For me it is also sufficient to check in rexpression.cpp:106 for type.inherits(QLatin1String("text/plain")) only - application/x-extension-html inherits apparently from text/plain.
> Your system, as I see, doesn't use application/x_extension-html (uses text/html instead), so you can remove condition for this mimetype without problem.
> But removing this condition for me gives:
> `cannot open file /tmp/cantor_rserver-14014/Rtable1.html: Unknown MimeType`
This would mean that application/x-extension-hmtl doesn't inherit from text/plain... Ok. Let's submit this. bool isHtml in line 110 can be defined const.
To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-edu