D12930: Fix regression with completed jobs being rescheduled erroneously.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added a reviewer: mutlaqja.
Restricted Application added a project: KDE Edu.
Restricted Application added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  A recent change made a completed job return to evaluation, in order to verify that duplicates were either complete too or needed repeats.
  This caused those completed jobs to be considered again for processing after being re-evaluated.
  This was an issue in the case option 'Remember Job Progress' was enabled, because Ekos would not run any capture and would stall the Scheduler.
  Filtering again on state after evaluating and before considering the next job solves the issue.

TEST PLAN
  Test with .esl "simple_test_no_twilight" with option 'Remember Job Progress' enabled.
  Without this change, selected job completes, but stays selected for next observation. Scheduler stalls.
  With this change, selected job completes, but is subsequently disregarded by the scheduler, as expected.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__job_complete (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12930

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180516/6a222205/attachment.html>