D12874: Piano_composition, add an indicator to highlight the currently selected note-type, minor refactoring and indentation corrections.

[Aman Kumar Gupta]

amankumargupta added inline comments.

INLINE COMMENTS

> Piano_composition.qml:203
> +            property var noteTypes: [1, 2, 4, 8]
> +            property var noteLengthName: ["whole-note", "half-note", "quarter-note", "eighth-note"]
>  

Will make these 2 variables readonly before committing. It completely got off my mind while creating the diff.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12874

To: amankumargupta, #gcompris_improvements
Cc: jjazeix, kde-edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180514/2a9e00de/attachment.html>