D12866: piano_composition, reafactor white and black keys into one.

Aman Kumar Gupta noreply at phabricator.kde.org
Mon May 14 09:08:07 UTC 2018


amankumargupta created this revision.
amankumargupta added a reviewer: GCompris: Improvements.
amankumargupta added a project: GCompris: Improvements.
Restricted Application added a project: KDE Edu.
Restricted Application added a subscriber: kde-edu.
amankumargupta requested review of this revision.

REVISION SUMMARY
  Much code in the white and black keys were repeated.
  A new file PianoKey.qml has been created and the common code is generalized and put into it.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12866

AFFECTED FILES
  src/activities/piano_composition/Piano.qml
  src/activities/piano_composition/PianoKey.qml

To: amankumargupta, #gcompris_improvements
Cc: kde-edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180514/1bbb1a40/attachment-0001.html>


More information about the kde-edu mailing list