D12784: CoreDirectoryTest

[Johnny Jazeix]

jjazeix accepted this revision.
jjazeix added a comment.
This revision is now accepted and ready to land.


  Good for me, you can commit it on the master branch.
  
  Thank you

INLINE COMMENTS

> DirectoryTest.cpp:48
> +    file.mkpath("./dummy_directory");
> +    QCOMPARE(file.exists("./dummy_directory"), true);
> +

I think you can directly Q_COMPARE on the mkpath that returns true if the folder has been created

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12784

To: himanshuvishwakarma, jjazeix
Cc: kde-edu, #gcompris, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180510/7ee6d866/attachment.html>