D12784: CoreDirectoryTest

[Johnny Jazeix]

jjazeix requested changes to this revision.
jjazeix added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> DirectoryTest.cpp:41
> +{
> +    // Removing the diretory of the previous test, If any.
> +    QDir dir("./dummy_directory");

directory

> DirectoryTest.cpp:46
> +    File file;
> +    file.mkpath("./dummy_directory");
> +    Directory directory;

you can add a QCOMPARE to be sure the folder has been created

> DirectoryTest.cpp:49
> +    QStringList filelist = directory.getFiles("./dummy_directory");
> +    // It counting the './' & '../' in directory.
> +    QCOMPARE(filelist.count(), 2);

It counts

> DirectoryTest.cpp:65
> +    QCOMPARE(filelist.count(), 8);
> +}
> +

I would still remove the folder at the end of the function too

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12784

To: himanshuvishwakarma, jjazeix
Cc: kde-edu, #gcompris, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180509/fff5c705/attachment.html>