D11696: explore_farm_animals, In level 2, play first a jingle before the next animal sound

[Johnny Jazeix]

jjazeix requested changes to this revision.
jjazeix added a comment.
This revision now requires changes to proceed.


  Hi,
  
  thank you for your patch. I think it can be simplified without adding to add too much code.
  
  Johnny

INLINE COMMENTS

> explore-level.js:122
> +        // Play the .audio when it's the first SubSubLevel and then .delayedAudio
> +        if (IsNext == 0) {
> +            items.audioVoices.play(getCurrentQuestion().audio);

why not using directly "silence" property of GCAudio (https://cgit.kde.org/gcompris.git/tree/src/core/GCAudio.qml#n168)?

> explore-level.js:132
>  function nextSubSubLevel() {
> -    initSubSubLevel()
> +    initSubSubLevel(1)
>  }

if it's a boolean value, better use true/false

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11696

To: jonathand, #gcompris_activities, jjazeix
Cc: jjazeix, #kde_edu, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180326/de8c4a72/attachment.html>