D11588: Fix broken octave backend and debug messages small change
Alexander Semke
noreply at phabricator.kde.org
Sun Mar 25 12:10:51 UTC 2018
asemke added a comment.
this problem can be solved in a more simple way by adding
if (!m_loginDone && m_session->backend()->name() == QLatin1String("Octave"))
loginToSession();
in Worksheet::enableHighlighting(). This fix would be similar to d2bb5bbc44e23eadfdb21b772bd94222b29e9e42 <https://phabricator.kde.org/R55:d2bb5bbc44e23eadfdb21b772bd94222b29e9e42> with a similar problem for the completion.
The idea behind the postponed login is described in T4760 <https://phabricator.kde.org/T4760>. These fixes now make the second point described in T4760 <https://phabricator.kde.org/T4760> impossible. We'll need to refactor this I guess.
Independent of how the final/temporary fix will look like, we urgently need to fix this for the 18.04 release.
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D11588
To: sirgienko, #cantor
Cc: asemke, #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180325/d600ad7b/attachment.html>
More information about the kde-edu
mailing list