D11343: T1513

[Ferencz Kovacs]

ferenczkovacs added inline comments.

INLINE COMMENTS

> fkristof wrote in TextLabel.cpp:991
> You should move m_labelShape (instead of m_labelshape) to TextLabelPrivate. That way you won't need any getter, you can just set it in TextLabelPrivate. You should also rename this function to recalcShapeAndBoundingRect(TextLabel::LabelShape) too.

I don't think so, because then i'll need a plus set of set-get functions

> fkristof wrote in TextLabel.h:78
> Remove this getter, you've got already
> 
>   TextLabel::LabelShape getLabelShape();

I'll rather use const int getLabelShapeint(); 
and delete 
TextLabel::LabelShape getLabelShape();

> fkristof wrote in TextLabel.h:159
> Move these members to TextLabelPrivate.

I'll pass if possible, i'll need unnecessarily an additional set/get function pair

> fkristof wrote in LabelWidget.cpp:794
> This isn't the way you load the configuration. Check the other parameters how they are saved and then loaded here from the config file.

can't manage to solve it

> fkristof wrote in LabelWidget.h:64
> What does this represent? The name isn't very self-describing.

a copy of the temporary shape, i think it's quite clear

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D11343

To: ferenczkovacs, fkristof
Cc: asemke, #kde_edu, garvitkhatri, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180321/81f20b64/attachment.html>