D11034: CoreApplicationSettingsTest

[Himanshu Vishwakarma]

himanshuvishwakarma updated this revision to Diff 30148.
himanshuvishwakarma added a comment.


  I am doing the mistake in the adding a protected constructor so, it gives the ambiguity error.
  
  Now, I add a protected constructor taking the path as parameter and use it in to instantiate the inherited class and it working fine.
  
  I also add a function: getConstructor() in private to the class ApplicationSettings because the same code is repeating again and again in the constructor.

REPOSITORY
  R2 GCompris

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11034?vs=30019&id=30148

REVISION DETAIL
  https://phabricator.kde.org/D11034

AFFECTED FILES
  CMakeLists.txt
  src/core/ApplicationSettings.cpp
  src/core/ApplicationSettings.h
  tests/core/ApplicationSettingsTest.cpp
  tests/core/CMakeLists.txt

To: himanshuvishwakarma, jjazeix, dmadaan, rudranilbasu, timotheegiet, #gcompris
Cc: #kde_edu, #gcompris, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180321/2c524dbd/attachment.html>