D11225: Remove scrolling on sliders in config menu

Johnny Jazeix noreply at phabricator.kde.org
Sun Mar 11 20:35:41 UTC 2018


jjazeix added inline comments.

INLINE COMMENTS

> ConfigurationItem.qml:1
> +
>  /* GCompris - ConfigurationItem.qml

not needed

> ConfigurationItem.qml:290
>                  updateValueWhileDragging: true
>                  value: baseFontSize

not needed (it's already true by default)

> ConfigurationItem.qml:293
>                  onValueChanged: ApplicationSettings.baseFontSize = value;
> +                MouseArea { // Removes scrolling when hovering sliders
> +                    anchors.fill: parent

could be factorised on a separate item (https://phabricator.kde.org/T8182)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11225

To: abreton, #gcompris_improvements, timotheegiet
Cc: jjazeix, timotheegiet, #kde_edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180311/f6addf41/attachment.html>


More information about the kde-edu mailing list