D10950: CoreActivityInfoTest

[Himanshu Vishwakarma]

himanshuvishwakarma marked 2 inline comments as done.
himanshuvishwakarma added inline comments.

INLINE COMMENTS

> jjazeix wrote in CMakeLists.txt:462
> if you use automoc, can you remove the qt5_wrap_cpp in the src/core folder and check if it still works?
> You may need to move this line higher on the file to also apply to src subdirectory

During the writing the test, I don't want to touch the core part of the application. Today I tried to remove the qt5_warp_cpp but it makes complex to handle both the test and application. Maybe I am doing wrong way also. I will try more to make compiled the c++ code once.

> jjazeix wrote in activityinfotest.cpp:6
> why do you need this?

I just added by mistake

> jjazeix wrote in activityinfotest.cpp:41
> do you need a pointer here?

No, Really no needed of the pointer. It is in my practice. Now pointer is removed

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D10950

To: himanshuvishwakarma, #gcompris, jjazeix, dmadaan, rudranilbasu, timotheegiet
Cc: #kde_edu, #gcompris, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180302/c813304f/attachment.html>