D13711: Support import of ROOT (CERN) TH1 histograms

Christoph Roick noreply at phabricator.kde.org
Tue Jun 26 18:06:59 UTC 2018


croick marked 7 inline comments as done.
croick added a comment.


  Thank you for your quick feedback.
  
  Maybe the initial patch was submitted a little precoiously, the latest diff includes quite a few changes (sorry for that) which should improve the usability:
  
  - Don't make use of the data portion widget, but use checkboxes for the selection of columns.
  - Also the bin ranges are now selected on the same options page and are adjusted according to the selected histogram.
    - This might require later changes; if somebody wants to import multiple histograms with different numbers of bins.

INLINE COMMENTS

> fkristof wrote in ROOTOptionsWidget.cpp:72
>   const auto&

Actually they are pointers, so I used `auto*` to make that clear.

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D13711

To: croick, sgerlach, asemke, fkristof
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180626/b0e002dd/attachment.html>


More information about the kde-edu mailing list