D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction
Martin Koller
noreply at phabricator.kde.org
Wed Jun 20 21:15:02 UTC 2018
mkoller created this revision.
mkoller added reviewers: nienhueser, Marble.
Restricted Application added projects: Marble, KDE Edu.
Restricted Application added subscribers: kde-edu, marble-devel.
mkoller requested review of this revision.
REVISION SUMMARY
When one starts to spin the globe with the mouse (kinetic rotation) and while the kinetic rotation is still being
processed, setting a new position (e.g. via MarbleWidget::flyTo or via the keyboard, e.g. Home button, etc.)
two movements interfere: the kinetic rotation of the earth started by the input handler and the second animation via
the physics timeline done in the presenter.
This patch introduces a new method in the input handler to stop a possible pending earth rotation and
calls it on the different places needed.
TEST PLAN
manual testing via mouse and keyboard and with a secondary application which can call flyTo() programmatically
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D13640
AFFECTED FILES
lib/marble/MarbleInputHandler.cpp
lib/marble/MarbleInputHandler.h
lib/marble/MarbleWidget.cpp
To: mkoller, nienhueser, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180620/1b7a2827/attachment.html>
More information about the kde-edu
mailing list