D13469: Keep job removal icon disabled when Scheduler stops

Eric Dejouhanet noreply at phabricator.kde.org
Sun Jun 10 20:24:41 UTC 2018


TallFurryMan created this revision.
TallFurryMan added a reviewer: mutlaqja.
Restricted Application added a project: KDE Edu.
Restricted Application added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  This change prevents the job removal icon from being enabled when the Scheduler stops, as this may cause the user to delete a job without any preliminary hint on which job will be removed.

TEST PLAN
  Add a few jobs to the scheduler, check the removal icon: it is enabled only if a job is selected in edit mode.
  Start the scheduler, then stop the scheduler, check the removal icon.
  Without the change, the removal icon is unexpectedly enabled, and no hint of any job to be deleted is visible.
  Clicking the removal icon effectively removes a job.
  With the change, the removal icon remains properly disabled until a job is selected, preventing the user from deleting any job.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__remove_icon_on_scheduler_stop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13469

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180610/abf6f456/attachment.html>


More information about the kde-edu mailing list