D14523: [import] Update file content overview after file type change

Christoph Roick noreply at phabricator.kde.org
Tue Jul 31 21:15:30 BST 2018


croick marked 3 inline comments as done.
croick added inline comments.

INLINE COMMENTS

> asemke wrote in ImportFileWidget.cpp:624
> const QString& fileName

You meant `const QString fileName`, right?

> asemke wrote in ImportFileWidget.cpp:773
> const QString& fileName

You meant `const QString fileName`, right?

> asemke wrote in ImportFileWidget.cpp:843
> const QString& name

Cannot make it const, it's modified later on.

> asemke wrote in ImportFileWidget.h:111
> should this really be a slot?

No, but there were only slots so far (also unconnected).

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D14523

To: croick, #labplot
Cc: asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180731/82632b77/attachment.html>


More information about the kde-edu mailing list