D14411: Download and use localization files for KStars Lite

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> catalogdb.cpp:606
> +#else
>                      errs.append(i18n("Parsing header: ") + i18n("Extra Delimiter field in header: %1."
>                                                                  "  Will be ignored",

Nice, so many string puzzles in this file... will fix them.

> apol wrote in colorscheme.cpp:113
> It's a warning, maybe not really worth translating ever?

Yup, will fix it.

> clientmanagerlite.cpp:242
>          {
> +            QString temp = QString(i18n("Web Manager Status:"))+' '+i18n("Online");
> +

These changes are basically no-nops. Also, more string puzzles to fix...

> LocationEdit.qml:424
>                          } else {
> -                            notification.showNotification(xi18n("Added new location - " + fullName))
> +                            notification.showNotification(i18n("Added new location - %1", fullName))
>                          }

This almost looked like a good change... if not for the switch from `xi18n` to `i18n`. Anyway, will fix this string puzzle too...

> TimeSpinBox.qml:169
>          if ( ! daysOnly ) {
> -            timeString.push( "0 " + i18np( "seconds", "secs" ));
> -            timeString.push( "0.1 " + i18np( "seconds", "secs" ));
> -            timeString.push( "0.25 " + i18np( "seconds", "secs" ));
> -            timeString.push( "0.5 " + i18np( "seconds", "secs" ));
> -            timeString.push( "1 " + i18np( "second", "sec" ));
> -            timeString.push( "2 " + i18np( "seconds", "secs" ));
> -            timeString.push( "5 " + i18np( "seconds", "secs" ));
> -            timeString.push( "10 " + i18np( "seconds", "secs" ));
> -            timeString.push( "20 " + i18np( "seconds", "secs" ));
> -            timeString.push( "30 " + i18np( "seconds", "secs" ));
> -            timeString.push( "1 " + i18np( "minute", "min" ));
> -            timeString.push( "2 " + i18np( "minutes", "mins" ));
> -            timeString.push( "5 " + i18np( "minutes", "mins" ));
> -            timeString.push( "10 " + i18np( "minutes", "mins" ));
> -            timeString.push( "15 " + i18np( "minutes", "mins" ));
> -            timeString.push( "30 " + i18np( "minutes", "mins" ));
> -            timeString.push( "1 " +xi18n( "hour" ));
> -            timeString.push( "2 " + i18np( "hours", "hrs" ));
> -            timeString.push( "3 " + i18np( "hours", "hrs" ));
> -            timeString.push( "6 " + i18np( "hours", "hrs" ));
> -            timeString.push( "12 " + i18np( "hours", "hrs" ));
> +            timeString.push( "0 " + xi18n( "seconds" ));
> +            timeString.push( "0.1 " + xi18n( "seconds" ));

All the handling of units in the existing QML source is already wrong...

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D14411

To: ckertesz, mutlaqja, pino, apol
Cc: apol, aacid, pino, kde-edu, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180728/6afdd4eb/attachment-0001.html>