D14411: Download and use localization files for KStars Lite

Pino Toscano noreply at phabricator.kde.org
Thu Jul 26 21:04:47 BST 2018

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.

  This does not look good for different reasons:
  - the KI18n framework is marked as working on Android (and looking at its git history, there were fixes for it); hence, if it still does not  work, please fix it instead (so it will work for kstars //any// any other KI18n-based application)
  - if you really need to define i18n() as gettext(), then wrap it as QString::fromUtf8(), otherwise the encoding is completely wrong (implicit char* -> QString cast uses latin1/ascii)
  - it mixes unrelated changes (like header reshuffling) -- please make sure each commit is **not** an aggregate of many unrelated changes!
  - all the various string changes, like the introduction of string puzzles, are big no-no
  Please get KI18n to work: all these changes are intrusive, and wrong, workarounds to that.

  R321 KStars


To: ckertesz, mutlaqja, pino
Cc: pino, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180726/67de3fc0/attachment.html>

More information about the kde-edu mailing list