D14005: Fix displaying commands source code in sage backend
Nikita Sirgienko
noreply at phabricator.kde.org
Mon Jul 9 16:50:56 BST 2018
sirgienko added a subscriber: asemke.
sirgienko added a comment.
Hi, thanks for patch.
I am afraid, that @filipesaraiva don't active in Cantor in this moment, so I recommend change @filipesaraiva to @asemke: another active Cantor developer.
What about removing this if condtions at all?
- if(command.endsWith(QLatin1Char('?')) && !command.endsWith(QLatin1String("??")))
- command=QLatin1String("help(")+command.left(command.size()-1)+QLatin1Char(')');
- if(command.startsWith(QLatin1Char('?')))
- command=QLatin1String("help(")+command.mid(1)+QLatin1Char(')');
As I see, this code don't need, because `sage` understand `foo?` and `?foo` as help request, so we don't need change `foo?` and `?foo` to `help(foo)` command. And this also make the source code command (`foo??`) working.
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D14005
To: arojas, filipesaraiva, sirgienko
Cc: asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180709/b5c33b32/attachment.html>
More information about the kde-edu
mailing list