D13890: Add variable manager and fix some unicode errors for R backend

Alexander Semke noreply at phabricator.kde.org
Sat Jul 7 07:05:51 BST 2018


asemke added inline comments.

INLINE COMMENTS

> rextensions.cpp:95
> +
> +QString RVariableManagementExtension::saveVariables(const QString& fileName)
> +    {

use Q_UNUSED(fileName) here.

> rsession.cpp:138
> +    m_variables = vars;
> +    for (size_t i = 0U; i < vars.count(); i++)
> +        {

use "int i" here to avoid signed vs. unsigned int comparisons

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D13890

To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180707/fc26bdba/attachment.html>


More information about the kde-edu mailing list