D13688: Store visibility of right panels ("Variables", "Help", etc) separately for each worksheet

Alexander Semke noreply at phabricator.kde.org
Mon Jul 2 05:49:57 UTC 2018


asemke added inline comments.

INLINE COMMENTS

> cantor.h:109
>  private:
> +    QMap<KParts::ReadWritePart*, QMap<QString, bool>> m_pluginsVisibilityMap;
>      QList<KParts::ReadWritePart *> m_parts;

why not to use a more simpler container QMap<KParts::ReadWritePart*, QStringList> and to store the names of the visible panels only? We don't need to track the invisible panels explicitly. If the name is not in the list, the panel is invisible.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D13688

To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180702/dad036ec/attachment.html>


More information about the kde-edu mailing list