D10004: Reposition score box in hangman activity(ref: T7777)

Johnny Jazeix noreply at phabricator.kde.org
Sun Jan 21 20:15:19 UTC 2018


jjazeix added a comment.


  There are a lot of elements on this activity that can make repositioning its components difficult: https://pasteboard.co/H3ZSP7v.png
  I think it would be better to reduce a bit the size of the OK button, same for score (maybe something like: width: internalTextComponent.width * 1.5 and height: internalTextComponentheight * 1.2, it's to be tested, I didn't checked if it rendered well).
  And setting the score at the place of the OK button and the OK button above it.

INLINE COMMENTS

> Hangman.qml:86
>              property int remainingLife
> -            property var goodWord
> +            property variant goodWord
>              property int goodWordIndex

why did you change this? variant is deprecated and should not be used

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D10004

To: rohitdas, #gcompris_improvements
Cc: jjazeix, asagtani, #kde_edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180121/0acfc656/attachment.html>


More information about the kde-edu mailing list