D9644: Explore activities: Fix progress bar overriding on resizing
Johnny Jazeix
noreply at phabricator.kde.org
Sun Jan 14 19:57:52 UTC 2018
jjazeix added inline comments.
INLINE COMMENTS
> ExploreLevels.qml:58
> }
> -
> + property bool vert: background.width < background.height
> property bool horizontalLayout: background.width > background.height
no need to add this, you already have horizontal just below that you can use.
Use a full name too instead of abbreviations
> ExploreLevels.qml:161
> id: progressbar
> - height: questionText.height
> - width: background.width / 2.5
> + height: bar.height
> + width: bar.width
remove the space at the end
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D9644
To: ganeshredcobra, #gcompris
Cc: jjazeix, #kde_edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180114/c17a98d0/attachment.html>
More information about the kde-edu
mailing list