D9837: core, add subLevelText alias in Score.qml

Johnny Jazeix noreply at phabricator.kde.org
Sat Jan 13 20:54:36 UTC 2018


jjazeix accepted this revision.
jjazeix added a comment.
This revision is now accepted and ready to land.


  Once fixed, you can commit directly on master.
  
  Thank you

INLINE COMMENTS

> Score.qml:74
> +     */
> +    property alias subLevelText: subLevelText
> +

As it should only be used for setting the font size, I would rename the alias for external reference. Something like internalTextComponent, to insist on the fact it should be used carefully.
Is it possible to make it readonly?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9837

To: asagtani, #gcompris, jjazeix
Cc: asagtani, #kde_edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180113/9e847706/attachment.html>


More information about the kde-edu mailing list