D10394: KDE Applications version string is added to Parleys version string

[Albert Astals Cid]

aacid added a subscriber: kde-edu.
aacid added a comment.


  In https://phabricator.kde.org/D10394#203970, @hriesenbeck wrote:
  
  > OK I see.
  >
  > Since cmake wants the version string in this format: VERSION <major>[.<minor>[.<patch>[.<tweak>]]], a more complex version string, which include both, parleys version string and the complete KDE Applications version string, is not practicable. Using the KDE Apps micro version as extension to parleys version, as shown in the guide as example, seems to be no advantage to me. Since the micro version repeats every release.
  >
  > So I see only two ways. Leave it as it is or use only the KDE Apps version string.
  >
  > I lean towards the second way. But may there is a third way, which I do not see...
  >  What do you think?
  
  
  The bottom line here, is someone needs to care about the application version. Right now noone is, so it's stuck in 2.1.0 for 2 years.
  
  If you're willing to commit the changes, you can manually increase the version before each release (we have a calendar for that).
  
  If you're not (and i understand that, not trying to blame you or anything) you must use an automatic way like we're trying in this code review.
  
  You're right that the auto increasing micro version like we do in Okular still needs manual intervention for each "non point" release.
  
  If we don't want to do that we must use a totally automatic way to do it, that is using KDE_APPLICATIONS_VERSION directly, or if we were to be nasty i guess one could do some calculation like 2.X.KDE_APPLICATIONS_VERSION_MICRO  where X is (KDE_APPLICATIONS_VERSION_MAJOR-16)*3+KDE_APPLICATIONS_VERSION_MINOR/4 (math to be checked this actually produces an increasing version number). But I'm not sure that really sounds like a good idea either, so i'll leave it up to you:
  a) You commit to increase the version for every release
  b) You commit to increase the version for every non-point release and just use KDE_APPLICATIONS_VERSION_MICRO
  c) You perfect my formula and convince me it won't break and it's a good idea
  d) We use KDE_APPLICATIONS_VERSION directly
  
  Any of the options is good for me.  Anyone else at @kde-edu has an opinion?

REPOSITORY
  R340 Parley

REVISION DETAIL
  https://phabricator.kde.org/D10394

To: hriesenbeck, #kde_edu
Cc: kde-edu, aacid, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180210/147084c2/attachment-0001.html>