D17850: Tutorial screen added for odd even activity

Yuri Chornoivan noreply at phabricator.kde.org
Sat Dec 29 12:48:34 GMT 2018


yurchor added a comment.


  Thanks in advance for fixing issues.

INLINE COMMENTS

> planegame.js:49
> +            {
> +                "instruction": qsTr("Even numbers are those numbers which ends with 0 , 2 , 4 , 6 , 8."),
> +                "instructionQml" : "qrc:/gcompris/src/activities/planegame/resource/tutorial1.qml"

This is not the classic definition. It holds true for the decimal system only.

https://en.wikipedia.org/wiki/Parity_(mathematics)

> tutorial.qml:15
> +        anchors.centerIn: parent.Center
> +        text: "For example: \n 15, 19, 51 , 65 , 103 , \n 119 , 169 , 185 , 505 , 533 , \n 701 , 799 , 845 , 897 , 1001. \n All of these numbers  are odd numbers as all of these numbers \n doesn't ends with either 0,2,4,6,8."
> +        font.pixelSize: parent.height * 0.1

Typo: does not end -> do not end

> tutorial2.qml:19
> +        }
> +        text: qsTr( "Choose the even number ?")
> +        font.pixelSize: parent.height * 0.15

The question sign at the end is not needed.

> tutorial2.qml:116
> +   GCText {
> +        text: qsTr("No this is not an even numbers because it doesn't ends with 0,2,4,6,8.")
> +        font.pixelSize: parent.height * 0.1

Typo: No -> No,
Typo : an even numbers -> an even number
Typo: doesn't ends -> doesn't end

> tutorial3.qml:20
> +
> +        text: qsTr( "Choose the even number ?")
> +        font.pixelSize: parent.height * 0.15

The question sign at the end is not needed.

> tutorial3.qml:117
> +    GCText {
> +        text: qsTr("No this is not an even numbers because it doesn't ends with 0,2,4,6,8.")
> +        font.pixelSize: parent.height * 0.1

Typo: No -> No,
Typo : an even numbers -> an even number
Typo: doesn't ends -> doesn't end

> tutorial4.qml:19
> +        }
> +        text: qsTr( "Choose the even number ?")
> +        font.pixelSize: parent.height * 0.15

The question sign at the end is not needed.

> tutorial4.qml:116
> +    GCText {
> +        text: qsTr("No this is not an even numbers because it doesn't ends with 0,2,4,6,8.")
> +        font.pixelSize: parent.height * 0.1

Typo: No -> No,
Typo : an even numbers -> an even number
Typo: doesn't ends -> doesn't end

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17850

To: dekumar
Cc: yurchor, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181229/7490e169/attachment-0001.html>


More information about the kde-edu mailing list