D17697: Fix the list of file types in Kig "Open File" dialog

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> tcanabrava wrote in kig.cpp:221
> I was aware of the blogpost you posted (and hoped not to see it again), It's from 2009 and I'm not sure it applies today, I need to test. but with that blogpost in mind, I would say "Meh, then it's good"
> 
> On the stack means that the variable is not a pointer,
> 
> QFileDialog dlg;
> dlg.exec();
> 
> but if that crashes the app because of dbus... not worth it.

There are some not so old examples. It might be hard to crash apps this way, but it seems feasible.

https://phabricator.kde.org/D7285

REPOSITORY
  R331 Kig

REVISION DETAIL
  https://phabricator.kde.org/D17697

To: yurchor, #kde_edu, pino, tcanabrava
Cc: tcanabrava, aacid, cfeck, pino, apol, kde-edu, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181224/031ba6ad/attachment-0001.html>