D17697: Fix the list of file types in Kig "Open File" dialog

[Tomaz Canabrava]

tcanabrava accepted this revision.
tcanabrava added inline comments.

INLINE COMMENTS

> yurchor wrote in kig.cpp:221
> Alms for the poor... I'm not a professional system programmer (it's obvious from the code, I think).
> 
> This is the recommended approach to deal with such cases:
> 
> https://blogs.kde.org/node/3919
> 
> I just followed the pattern as you have observed.
> 
> I have tried to make it like this:
> 
> https://phabricator.kde.org/D17738
> 
> but it does not compile.
> 
> I tried to google "creating QObjects on the stack"  but it does not give some fast results. Can you recommend something to read about this?

I was aware of the blogpost you posted (and hoped not to see it again), It's from 2009 and I'm not sure it applies today, I need to test. but with that blogpost in mind, I would say "Meh, then it's good"

On the stack means that the variable is not a pointer,

QFileDialog dlg;
dlg.exec();

but if that crashes the app because of dbus... not worth it.

REPOSITORY
  R331 Kig

REVISION DETAIL
  https://phabricator.kde.org/D17697

To: yurchor, #kde_edu, pino, tcanabrava
Cc: tcanabrava, aacid, cfeck, pino, apol, kde-edu, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181224/aef8b5f0/attachment.html>