D17403: Copy root value or (x,y) pair to clipboard

[Tomaz Canabrava]

tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> tcanabrava wrote in view.h:215
> this should be const. please take a look on const correctness <https://isocpp.org/wiki/faq/const-correctness>

Sorry, you added the wrong const.

const QPointF getCrosshairPosition(); means that the QPointF that's being returned is a const.

QPointF getCrosshairPosition() const; means that the *method* is constant and cannot change the this-pointer or any internals.

take the time to look at the link I provided about const correctness.

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D17403

To: yurchor, #kde_edu, tcanabrava
Cc: tcanabrava, aacid, kde-doc-english, kde-edu, skadinna, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181224/b50f21ac/attachment.html>