D17720: Allow direct link to the help page when the "Help" button is pressed in the settings window

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Dec 21 12:12:24 GMT 2018


apol added inline comments.

INLINE COMMENTS

> mainwindow.cpp:33
>  
> +#include <KCoreAddons>
>  #include <KDeclarative/KDeclarative>

Use kcoreaddons_version.h

> mainwindow.cpp:114
> +        // Allow direct link to the help page when the "Help" button is pressed in the settings window
> +        if (KCoreAddons::version() >= QT_VERSION_CHECK(5, 52, 0))
> +        {

This looks quite dirty, maybe make it public if it needs calling from outside?

REPOSITORY
  R327 Kanagram

REVISION DETAIL
  https://phabricator.kde.org/D17720

To: yurchor, #kde_edu
Cc: apol, kde-edu, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181221/723898bc/attachment.html>


More information about the kde-edu mailing list