D17626: [WIP] Print preview for KmPlot
    Yuri Chornoivan 
    noreply at phabricator.kde.org
       
    Sun Dec 16 16:21:25 GMT 2018
    
    
  
yurchor created this revision.
yurchor added a reviewer: KDE Edu.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
yurchor requested review of this revision.
REVISION SUMMARY
  A bit ugly attempt to implement print preview with an additional configuration widget.
  
  F6480632: print_prev.png <https://phabricator.kde.org/F6480632>
TEST PLAN
  1. Plot something.
  2. Choose "File -> Print Preview"
  3. Press the last button on the toolbar to configure the print options.
  4. Due to the obvious inability to repaint the image from the current code, no print preview update occurs after pressing the "Ok" button.
  5. Choose some other option (switch to the landscape mode and back). The preview should be updated with the parameters chosen on step 3.
  
  I need an advice on the quality of the code and how the update can be triggered in the right way (google only advices to trigger it in a programmatical way of pressing buttons on the toolbar that is surely unacceptable).
  
  Many thanks in advance for your reviews.
REPOSITORY
  R334 KmPlot
REVISION DETAIL
  https://phabricator.kde.org/D17626
AFFECTED FILES
  kmplot/kmplot_part.rc
  kmplot/maindlg.cpp
  kmplot/maindlg.h
To: yurchor, #kde_edu
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181216/3837a962/attachment-0001.html>
    
    
More information about the kde-edu
mailing list