D17494: Allow translation of the style plugin names in molecule viewer

Pino Toscano noreply at phabricator.kde.org
Sun Dec 16 10:18:32 GMT 2018

pino added a comment.

  In D17494#377824 <https://phabricator.kde.org/D17494#377824>, @yurchor wrote:
  > In D17494#377816 <https://phabricator.kde.org/D17494#377816>, @pino wrote:
  > > The approach here should be changed: instead of hardcoding the names of plugins in the `styleCombo`, they ought to be read directly from the `sceneModel()` of the GL widget. This way:
  > >
  > > 1. the strings come directly from avogadro itself, no more need to translate them in kalzium
  > > 2. the list of styles reflects what avogadro provides, so no more mismatch between what is hardcoded in kalzium vs the plugins avogadro has
  > > 3. the documentation of kalzium ought to better not list all the plugins/styles available, since they depend on what avogadro has (mentioning a couple is more than enough, IMHO)
  > >
  > >   This also means that more i18n work is needed in avogadro itself.
  > What is the way to proceed?
  The one I explained above.
  > It seems I have a good friction with the current Avogadro maintainers. What should be changed? The translations are in the repo and on Launchpad, just not packed by the distributions.
  Looking at avogadro 1.2.0 (Qt4 version), it seems they ship them, and at least the Debian packaging bundles them in the "avogadro" package.
  The other thing is making sure that avogadro actually uses them (which seems to be done in 1.2.0).
  > Should I abandon this revision for some better times?
  Following my suggestions would be a better way forward.
  > Could someone shake some salt of knowledge on my life about how to fix this "in model"?
  `ui.glWidget->sceneModel()` returns a `QAbstractItemModel`, which can be iterated using its API.
  > Why it was good to use such an approach for other parts of Kalzium (can be easily proven by searching "->addItem")?
  `git log` and find out who/why did that.

  R326 Kalzium


To: yurchor, #kde_edu, pino
Cc: kde-doc-english, pino, kde-edu, skadinna, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181216/eabf2326/attachment-0001.html>

More information about the kde-edu mailing list