D17494: Allow translation of the style plugin names in molecule viewer

[Pino Toscano]

pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> moleculeview.cpp:173
> +void MoleculeDialog::slotUpdateScenePlugin(int itemIndex) {
> +    const QString text = ui.styleCombo->itemData(itemIndex, Qt::UserRole).toString();
>      for (int i = 0; i < ui.glWidget->sceneModel().rowCount(QModelIndex()); ++i) {

this now uses an UserRole...

> moleculeview.cpp:176
>          QModelIndex index = ui.glWidget->sceneModel().index(i, 0);
>          if (text == ui.glWidget->sceneModel().data(index, Qt::DisplayRole)) {
>              ui.glWidget->sceneModel().setData(index, Qt::Checked, Qt::CheckStateRole);

... but this comparison is still with a DisplayRole, so it will never match

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D17494

To: yurchor, #kde_edu, pino
Cc: pino, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181215/b6991e5a/attachment-0001.html>