D17585: Fix print preview in Kig

Albert Astals Cid noreply at phabricator.kde.org
Sat Dec 15 10:46:42 GMT 2018


aacid accepted this revision.
aacid added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kig_part.cpp:885
>    QPrintPreviewDialog printPreview( &printer );
> -  doPrint( printer, document().grid(), document().axes() );
> +  connect( &printPreview, &QPrintPreviewDialog::paintRequested, [this, &printer]{
> +      doPrint( printer, document().grid(), document().axes() );

We should not use our printer but the printer the signal gives us. So it should be

connect( &printPreview, &QPrintPreviewDialog::paintRequested, [this](QPrinter *p){

I'll fix this myself and push it, saves some roundtrip between you and me that adds no value.

REPOSITORY
  R331 Kig

REVISION DETAIL
  https://phabricator.kde.org/D17585

To: yurchor, #kde_edu, aacid
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181215/360b3685/attachment.html>


More information about the kde-edu mailing list