D17507: Chess activity: display list of taken pieces

Smit Patil noreply at phabricator.kde.org
Thu Dec 13 13:24:08 GMT 2018


smitpatil marked an inline comment as done.
smitpatil added inline comments.

INLINE COMMENTS

> jjazeix wrote in TakenPiecesList.qml:26
> It will be really nice to have when we upgrade the minimal version of Qt but for now, it is Qt5.6 and Drawer has been added in Qt5.7 (https://doc.qt.io/qt-5.11/qml-qtquick-controls2-drawer.html).
> Let's keep it this way, and we'll merge this patch once we have updated the minimal version of Qt.

I used Rectangle with animation. Thus we don't lose the keyboard focus. we don't need to remove list to play the game. Thus the user can leave it open while playing the game

REVISION DETAIL
  https://phabricator.kde.org/D17507

To: smitpatil, #gcompris_improvements, jjazeix
Cc: timotheegiet, jjazeix, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181213/a12a6022/attachment.html>


More information about the kde-edu mailing list