D17455: Write unit tests for DownloadManager

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> CMakeLists.txt:28
>     DownloadManager.h
> +   TestDownloadManager.cpp
>     GComprisPlugin.cpp

The "core" CMakeLists.txt should not be changed.
The tests have their own folder.

> TestDownloadManager.cpp:1
> +#include "DownloadManager.h"
> +#include <QObject>

the license header is missing.
I think when this file will be in the tests/core folder, there won't be any problem including QTest

> main.cpp:38
>  
> +#include "TestDownloadManager.cpp"
> +//#include <QtTest/QTest>

this should not be in the src/core/main.cpp file which is used to run the application.
We don't want to "pollute" the real play with unit tests ;)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17455

To: alexkovrigin, jjazeix
Cc: alexkovrigin, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181209/58798652/attachment.html>